[bugfix] Release JNI buffers after primitive array conversion (#102)

Author: bgeng777

src/main/c/pemja/core/pyutils.c

@@ -631,6 +631,7 @@ JcpAPI_FUNC(PyObject*)
     PyTuple_SetItem(result, i, JcpPyBool_FromLong(booleans[i]));
   }
 
+  (*env)->ReleaseBooleanArrayElements(env, value, booleans, JNI_ABORT);
   return result;
 }
 
@@ -653,6 +654,7 @@ JcpAPI_FUNC(PyObject*)
     PyTuple_SetItem(result, i, JcpPyInt_FromInt(shorts[i]));
   }
 
+  (*env)->ReleaseShortArrayElements(env, value, shorts, JNI_ABORT);
   return result;
 }
 
@@ -674,6 +676,7 @@ JcpAPI_FUNC(PyObject*) JcpPyTuple_FromJIntArray(JNIEnv* env, jintArray value) {
     PyTuple_SetItem(result, i, JcpPyInt_FromInt(ints[i]));
   }
 
+  (*env)->ReleaseIntArrayElements(env, value, ints, JNI_ABORT);
   return result;
 }
 
@@ -696,6 +699,7 @@ JcpAPI_FUNC(PyObject*)
     PyTuple_SetItem(result, i, JcpPyInt_FromLong(longs[i]));
   }
 
+  (*env)->ReleaseLongArrayElements(env, value, longs, JNI_ABORT);
   return result;
 }
 
@@ -718,6 +722,7 @@ JcpAPI_FUNC(PyObject*)
     PyTuple_SetItem(result, i, JcpPyFloat_FromDouble(floats[i]));
   }
 
+  (*env)->ReleaseFloatArrayElements(env, value, floats, JNI_ABORT);
   return result;
 }
 
@@ -740,6 +745,7 @@ JcpAPI_FUNC(PyObject*)
     PyTuple_SetItem(result, i, JcpPyFloat_FromDouble(doubles[i]));
   }
 
+  (*env)->ReleaseDoubleArrayElements(env, value, doubles, JNI_ABORT);
   return result;
 }
 

src/test/java/pemja/core/PythonInterpreterTest.java

@@ -25,6 +25,7 @@
 import java.io.File;
 import java.io.FileNotFoundException;
 import java.io.IOException;
+import java.lang.reflect.Array;
 import java.math.BigDecimal;
 import java.math.BigInteger;
 import java.nio.file.Files;
@@ -247,6 +248,35 @@ public void testCallPython() {
         }
     }
 
+    @Test
+    public void testInvokeMethodWithPrimitiveArrays() {
+        PythonInterpreterConfig config =
+                PythonInterpreterConfig.newBuilder().addPythonPaths(testDir).build();
+        try (PythonInterpreter interpreter = new PythonInterpreter(config)) {
+            interpreter.exec("import test_call");
+            Object[][] cases = {
+                {new boolean[] {true, false}, new Object[] {true, false}},
+                {new short[] {1, 2}, new Object[] {1L, 2L}},
+                {new int[] {1, 2}, new Object[] {1L, 2L}},
+                {new long[] {1, 2}, new Object[] {1L, 2L}},
+                {new float[] {1.5f, 2.5f}, new Object[] {1.5d, 2.5d}},
+                {new double[] {1.5, 2.5}, new Object[] {1.5d, 2.5d}}
+            };
+            for (Object[] testCase : cases) {
+                Object array = testCase[0];
+                assertArrayEquals(
+                        (Object[]) testCase[1],
+                        (Object[])
+                                interpreter.invokeMethod("test_call", "test_call_one_arg", array));
+                Object empty = Array.newInstance(array.getClass().getComponentType(), 0);
+                assertArrayEquals(
+                        new Object[0],
+                        (Object[])
+                                interpreter.invokeMethod("test_call", "test_call_one_arg", empty));
+            }
+        }
+    }
+
     @Test
     public void testCallPythonWithAllTypes() throws Exception {
         PythonInterpreterConfig config =