Skip to content

Enable compression on saved EXR. - #16948

Merged
comfyanonymous merged 1 commit into
masterfrom
exr_save_16
Oct 10, 2026
Merged

comfyanonymous merged 1 commit into
masterfrom
exr_save_16

Conversation

@comfyanonymous

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: da41e100-0b41-4b2c-9f8f-e18d418631d3

📥 Commits

Reviewing files that changed from the base of the PR and between 0df64eb and 5ab4226.


📒 Files selected for processing (1)
  • comfy_extras/nodes_images.py

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:


Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📜 Recent review details
⏰ Context from checks skipped due to timeout. (8)
  • GitHub Check: test (ubuntu-latest)
  • GitHub Check: test (windows-2022)
  • GitHub Check: test (macos-latest)
  • GitHub Check: Run Pylint
  • GitHub Check: test
  • GitHub Check: test (macos-latest)
  • GitHub Check: test (windows-latest)
  • GitHub Check: test (ubuntu-latest)

🧰 Additional context used
📚 Code guidelines (1)
AGENTS.md — configured

📓 Path-based instructions (3)
Community-contributed extra nodes.

⚙️ CodeRabbit configuration file

Files:

  • comfy_extras/nodes_images.py

IMPORTANT: Only comment on issues directly introduced by this PR's code changes.

⚙️ CodeRabbit configuration file

Files:

  • comfy_extras/nodes_images.py

Source excerpt: Keep changes small and direct.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • comfy_extras/nodes_images.py

🔀 Multi-repo context Comfy-Org/ComfyUI_frontend, Comfy-Org/comfy-kitchen

Linked repositories findings

Comfy-Org/ComfyUI_frontend

  • EXR outputs that cannot load as <img> are intentionally handled through “Download Images” for multiple outputs. [::Comfy-Org/ComfyUI_frontend::] src/composables/graph/useImageMenuOptions.test.ts:94-112
  • Opening and saving images use the /view URL directly after removing only the preview parameter; no compression-specific behavior is assumed. [::Comfy-Org/ComfyUI_frontend::] src/composables/graph/useImageMenuOptions.ts:55-63,97-106
  • Saved output URLs are constructed from result metadata via /view, with no format or compression validation. [::Comfy-Org/ComfyUI_frontend::] src/renderer/extensions/vueNodes/widgets/utils/savedImageUrls.ts:11-21
  • The frontend uses EXRLoader for HDR viewing, but no zip16 or encoding-setting dependency was found. [::Comfy-Org/ComfyUI_frontend::] src/composables/useHdrViewer.ts:2,63

Comfy-Org/comfy-kitchen

  • The broad search found no EXR, zip16, or image-encoding references, indicating no related kernel/backend consumer. [::Comfy-Org/comfy-kitchen::]

🔇 Additional comments (1)
comfy_extras/nodes_images.py (1)

1698-1698: LGTM!



📝 Walkthrough

Walkthrough

The EXR encoding configuration now requests zip16 compression. The existing half or float format selection remains unchanged.


Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 5ab42

EXR saving now requests zip16 while preserving the existing half/float format selection. The available compatibility evidence supports the change, with no identified merge-blocking risk.

Architecture Summary

Architecture risk: 🔵 Low · up to 5ab42

The change affects 1 system.

Changed systems: comfy_extras

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — comfy_extras (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in comfy_extras/nodes_images.py: EXR encoding now requests zip16 compression in addition to selecting half or float format.

Pre-merge checks | Passed 4 | Inconclusive 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check Inconclusive No pull request description was provided, so the description cannot be evaluated for relevance to the EXR compression change. Add a brief description that states the saved EXR files now use ZIP16 compression.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: enabling compression for saved EXR files.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@comfyanonymous
comfyanonymous merged commit ad30981 into master Oct 10, 2026
17 checks passed
@comfyanonymous
comfyanonymous deleted the exr_save_16 branch October 10, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants