Skip to content

Add CSS Mixins explainer - #1413

Open
John Jansen (thejohnjansen) wants to merge 4 commits into
mainfrom
user/johnjansen/css-mixins
Open

John Jansen (thejohnjansen) wants to merge 4 commits into
mainfrom
user/johnjansen/css-mixins

Conversation

@thejohnjansen

Copy link
Copy Markdown
Contributor

Creating an explainer for the work we're doing for CSS-Mixins-1. The current explainer is a publicly hosted document that contains outdated information and includes zincing (@functions). We should have a new one limited down to Mixins.

Old Explainer: https://css.oddbird.net/sasslike/mixins-functions/

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 2 Medium severity

Open (2)
What changed in this PR

Adds a new in-repo explainer for the CSS Mixins work and links it from the main README, replacing reliance on an older externally hosted explainer that includes outdated functions-focused content.

Changes:

  • Add a “CSS Mixins” entry to the README explainer index
  • Introduce a new CSSMixins/explainer.md documenting the current mixins authoring model and status
File Description
README.md Adds the CSS Mixins explainer to the repository’s explainer index
CSSMixins/​explainer.md New explainer document describing the current CSSWG direction for CSS mixins

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CSSMixins/explainer.md Outdated
Comment thread CSSMixins/explainer.md
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The explainer contains outdated draft-status text and incorrect internal and ChromeStatus links.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
Resolved since last review (2)
Previously missed (2)

In code that hasn't changed since last review

Low severity Outdated claim that the draft does not define mixins

CSSMixins/​explainer.md:23

This status is already outdated: the current Editor’s Draft contains normative @mixin, @apply, and @private sections. Saying that it does not define mixins misleads readers about the proposal’s current maturity; retain only the experimental-status caveat.

Low severity Incorrect ChromeStatus feature ID in link

CSSMixins/​explainer.md:49

This uses the Chromium tracking issue ID as a ChromeStatus feature ID. The CSS Mixins ChromeStatus entry linked from the TAG review is 5108022310469632; point this feature-entry link there instead.

This issue also appears on line 215 of the same file.

Comment thread CSSMixins/explainer.md
* [Accessibility, internationalization, privacy, and security](#accessibility-internationalization-privacy-and-security)
* [Resolved design choices](#resolved-design-choices)
* [Remaining questions and status](#remaining-questions-and-status)
* [References](#references)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants