Repository navigation
Set fallback encoding to Latin1 as the special case are likely single byte encoding rather than UTF-x - #1027
Merged
Conversation
… byte encoding rather than UTF-x
#Conflicts: # CMakeLists.txt
Murmele
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been laying around for a bit, and built upon #991 including a regression test for a bug fixed in the PR
Essentially, some dictionary files use an encoding that's not detected by the current code. This results in the spell checker failing to correctly parse word containing single byte characters that are not UTF-8 compatible (so essentially has a byte value of
0x80or higher). One example is shown with the German dictionaryBefore the fix we get a red underline for a correctly spelled word
After the fix, it's recognised and we see that non-German words still get a red line under it.
