Repository navigation
Conversation
A header/footer image had no alternative text in Xlsx: the VML writer put only the name into o:title of v:imagedata. Excel keeps the alternative text in the alt attribute of v:shape (ECMA-376 Part 4), so the description is now written there when set, and read back.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why is this change needed?
Fixes #5056.
The description of a header/footer image was dropped on write and not read. Excel keeps it in the
altattribute of the image's VML shape;o:titlestays the name. Checked in Excel for Windows: Alt Text set on a header picture is saved there, and Format Picture shows the description of an image written with this change.altonv:shapewhen the description is set; nothing changes without one.altback intosetDescription().Writer\Xlsx\HeaderFooterImageDescriptionTestfails onmaster.