feat(dashboard): end onboarding with a compact plan step by izadoesdev · Pull Request #1096 · databuddy-analytics/Databuddy

izadoesdev · 2026-10-08T13:23:05Z

Cherry-pick of staging 8c5517d.

Why

New owners finished onboarding without ever seeing what paid plans give them. A plan checkpoint added earlier sat between feature picks and setup and dropped the full Billing table into the flow, before the user had connected anything.

What changes

After the setup checklist, owners and admins on cloud get a final Pick a plan step. Self-hosted installs and members without billing rights skip it.
One card in the checklist's style: current plan, then a row per plan with its monthly allowances (events, investigations), price, and upgrade action. The footer opens the dashboard or Insights, so an upgrade made here unlocks "Open Insights" immediately.
Checkout returns to the same step (website and step=plan are kept in the URL).
The preview, confirm, and checkout logic is extracted from PricingCard into a shared PlanButton, so Billing and onboarding buy plans the same way.
Billing provider now reports real isError/isFetching; the plans error state has a retry.

Verification

Dashboard e2e (chromium, local): core onboarding (fresh account through the plan step, back to setup, reload on the plan step), plan-step billing recovery and checkout return, verified-onboarding regression, and billing-controls regression all pass.
Dashboard typecheck and Biome clean on this branch.
Not checked: mobile widths, and rendering with live Autumn plans (e2e uses a mocked plan list).

Summary by cubic

Adds a final Pick a plan step after the onboarding setup checklist so cloud owners and admins can upgrade before opening the dashboard.

The step is gated by the onboarding-plan-step flag and a live billing build; self-hosted installs, E2E, members without billing rights, and billing failures skip it.
One compact card lists each plan's monthly events and investigations allowance, price, and upgrade action, then opens the dashboard or Insights; checkout returns to the same step=plan URL, so a completed upgrade unlocks "Open Insights" right away.
Extracts preview, confirm, and checkout logic from PricingTable into a shared PlanButton, and billing reports isError/isFetching only when its data is missing, so a failed plan list or background refetch no longer turns Open Insights into Open dashboard.
Returning from checkout or a reload no longer repeats the onboarding-started and tracking-verified events; going back to setup re-records tracking verification, and the "Skip setup" button is removed from the interests step.
E2E coverage runs on a key-gated public fixture that checks plan rows, retry after the plan list fails, and checkout returning to the plan step.

^{Written for commit 4950c0c. Summary will update on new commits.}

Rollout

The step is gated by the onboarding-plan-step flag on the dashboard's flag website (OXmNQsViBT-FOS_wZCTHc). Until that flag exists and is on for a user, onboarding behaves as it does today. Create it as a rollout flag at 50%. E2E runs with flags disabled, so the gate treats E2E as on.

Review fixes (`46f009b`)

Billing isError/isFetching only report missing billing data, so a failed plan list or a background refetch no longer turns Open Insights into Open dashboard.
Returning to the plan step from checkout or a reload no longer repeats onboarding_started and the tracking-verified events.

vercel · 2026-10-08T13:23:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
dashboard	Ready	Preview	Oct 10, 2026 5:23pm UTC
databuddy-status	Ready	Preview	Oct 10, 2026 5:23pm UTC
documentation	Ready	Preview	Oct 10, 2026 5:23pm UTC

unkey-deploy · 2026-10-08T13:23:21Z

The latest updates on your projects. Learn more about Unkey Deploy

Name	Status	Preview	Inspect	Updated (UTC)
links (preview)	Ready	Visit Preview	Inspect	Oct 10, 2026 5:22pm

coderabbitai · 2026-10-08T13:23:21Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 9aff033d-3114-4b89-8064-b6a437ecc30c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-08T13:23:42Z

Observability score · 31

poor · unchanged against main · no regression

1 instrumented · 0 partial · 8 dark

Fix first (3)

POST /api/test/e2e/session apps/dashboard/app/api/test/e2e/session/route.ts:172: wide-event, context, structured-errors, audit
GET /api/auth/:all* apps/dashboard/app/api/auth/[...all]/route.ts:60: wide-event, context, audit
POST /api/auth/:all* apps/dashboard/app/api/auth/[...all]/route.ts:64: wide-event, context, audit

_{evlog map v0.8.0 · how the score works · what each check expects}

greptile-apps · 2026-10-08T13:28:22Z

Confidence Score: 4/5

[Medium risk] Adds plan selection step to onboarding flow.

The flow appears sound, but the explicit text styling, callback naming, and nested-expression requirements must be satisfied before merging.

Findings

Required text classes are missing ▶
Finish choices are nested ▶
Callback names lack required suffix ▶

Summary

Adds a final plan step after onboarding setup for cloud users who can upgrade.

Shares checkout and confirmation through PlanButton.
Keeps the onboarding URL when checkout returns.
Exposes billing errors and fetching state, with a retry for loading plans.
Three repository style requirements need to be satisfied before merging.

izadoesdev explicitly acknowledged that “e2e uses a mocked plan list”; this known choice is not reported.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Pick features] --> B[Setup checklist]
  B --> C{Cloud and allowed to upgrade?}
  C -->|Yes| D[Pick a plan]
  C -->|No| G[Dashboard or Insights]
  D -->|Back| B
  D --> E[Preview and confirm]
  E -->|Checkout| F[Return to saved plan step]
  F --> D
  E -->|Updated directly| D
  D -->|Finish| G

_{Reviews (1) · Last reviewed commit: "feat(dashboard): end onboarding with a c..." · Reviewed by Greptile}

greptile-apps · 2026-10-08T13:28:26Z

+		<div className="h-full overflow-y-auto">
+			<div className="mx-auto w-full max-w-3xl px-4 py-6 sm:px-6 lg:py-10">
+				<div className="mb-4 flex items-center justify-between gap-3">
+					<h1 className="font-semibold text-xl">Pick a plan</h1>


Required text classes are missing

The new heading lacks text-balance, and the allowance paragraph lacks text-pretty. The UI guide requires these classes for headings and paragraphs. Add both before merging.

Context Used: .cursor/rules/ui-guidelines.mdc (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

greptile-apps · 2026-10-08T13:28:26Z

 					websiteId
-						? {
-								label: reviewPending
-									? "Checking Insights…"
-									: opensInsights
-										? "Open Insights"
-										: "Open dashboard",
-								onClick: finish,
-								loading: reviewPending || research.saving,
-								note: reviewFailed
-									? "Failed to check Insights."
-									: opensInsights
-										? "Your first review runs once there is enough history to compare."
-										: null,
-								onRetry: reviewFailed ? billing.refetch : undefined,
-							}
+						? offersPlans
+							? { label: "Continue", onClick: choosePlan }
+							: { ...leaveAction, onClick: finish }
 						: null


Finish choices are nested

The new finish expression nests one ternary inside another, which the repository guide forbids. Calculate the finish action separately with early returns or if statements so the three cases are easier to follow. This requirement must be satisfied before merging.

Context Used: Ultracite Rules - AI-Ready Formatter and Linter (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

greptile-apps · 2026-10-08T13:28:26Z

+	successPath,
+}: {
+	finish: NonNullable<SetupChecklistProps["finish"]>;
+	onBack: () => void;


Callback names lack required suffix

The new callback types use onBack and onPlanUpdated without the required Action suffix. The repository guide requires function properties in types to end with Action. Rename these properties and their callers before merging. The same rule applies to the new onPlanUpdated properties in PricingTable and PricingCard.

Context Used: Basic guidelines for the project so vibe coders don't fuck it up (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

FindMalek · 2026-10-09T17:36:01Z

found a small bug while reviewing this - offersPlans gates on billing.isLoading, so a reload while on step=plan (e.g. checkout return) briefly falls through to SetupChecklist until billing refetches, then flips to ChoosePlan. opened a stacked fix: #1111

After setup, owners and admins on cloud pick a plan from one card that lists each plan's monthly allowances, price and upgrade action, then open the dashboard or Insights. Checkout returns to the same step. (cherry picked from commit 8c5517d)

The plan step now also needs the onboarding-plan-step flag, so it can reach half of new owners first. Billing only reports an error or a pending check when its data is missing, so a failed plan list or a background refetch no longer turns Open Insights into Open dashboard. Returning to the plan step from checkout or a reload no longer repeats the onboarding started and tracking verified events. (cherry picked from commit efbd272)

…step Members without billing rights no longer see plans while billing loads or fails, the card no longer claims Free when billing failed, and going back to setup after checkout records tracking verification again. (cherry picked from commit 6fa430d)

E2E and self-host builds skip the Autumn provider, so the plan step crashed there. It now needs a live billing build and the onboarding-plan-step flag, and the e2e specs return to main's flow. The pricing table drops props only onboarding used, and the plan step file is named after its component.

E2E builds skip the Autumn provider in the app layout, so the plan step is exercised on a key-gated public fixture. It checks plan rows and allowances, recovery after the plan list fails, and that checkout returns to the onboarding plan step.

unkey-deploy Bot deployed to links - preview October 8, 2026 13:23

View deployment

vercel Bot deployed to Preview – databuddy-status October 8, 2026 13:23

View deployment

vercel Bot deployed to Preview – documentation October 8, 2026 13:24

View deployment

vercel Bot deployed to Preview – dashboard October 8, 2026 13:24

View deployment

This comment has been minimized.

Sign in to view

vercel Bot temporarily deployed to Preview – documentation October 8, 2026 13:27 Inactive

unkey-deploy Bot deployed to links - preview October 8, 2026 13:27

View deployment

vercel Bot deployed to Preview – databuddy-status October 8, 2026 13:27

View deployment

vercel Bot deployed to Preview – dashboard October 8, 2026 13:27

View deployment

greptile-apps Bot reviewed Oct 8, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview – documentation October 8, 2026 13:58 Inactive

unkey-deploy Bot deployed to links - preview October 8, 2026 13:58

View deployment

vercel Bot deployed to Preview – databuddy-status October 8, 2026 13:58

View deployment

vercel Bot deployed to Preview – dashboard October 8, 2026 13:58

View deployment

izadoesdev force-pushed the izadoesdev/onboarding-plan-step-release branch from 75a9c8a to fa6dc1c Compare October 9, 2026 13:49

unkey-deploy Bot deployed to links - preview October 9, 2026 13:49

View deployment

vercel Bot deployed to Preview – databuddy-status October 9, 2026 13:49

View deployment

vercel Bot deployed to Preview – documentation October 9, 2026 13:50

View deployment

vercel Bot deployed to Preview – dashboard October 9, 2026 13:50

View deployment

FindMalek mentioned this pull request Oct 9, 2026

fix(dashboard): keep the onboarding plan step up during a billing refetch #1111

Open

izadoesdev added 4 commits October 10, 2026 20:21

izadoesdev force-pushed the izadoesdev/onboarding-plan-step-release branch from fa6dc1c to 4950c0c Compare October 10, 2026 17:21

unkey-deploy Bot deployed to links - preview October 10, 2026 17:21

View deployment

vercel Bot deployed to Preview – databuddy-status October 10, 2026 17:22

View deployment

vercel Bot deployed to Preview – documentation October 10, 2026 17:23

View deployment

vercel Bot deployed to Preview – dashboard October 10, 2026 17:23

View deployment

Navigation Menu

Repository navigation

feat(dashboard): end onboarding with a compact plan step - #1096

feat(dashboard): end onboarding with a compact plan step#1096
izadoesdev wants to merge 5 commits into
mainfrom
izadoesdev/onboarding-plan-step-release

izadoesdev commented Oct 8, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

vercel Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

unkey-deploy Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 8, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

greptile-apps Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Oct 8, 2026

Uh oh!

greptile-apps Bot Oct 8, 2026

Uh oh!

greptile-apps Bot Oct 8, 2026

Uh oh!

FindMalek commented Oct 9, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

izadoesdev commented Oct 8, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What changes

Verification

Summary by cubic

Rollout

Review fixes (46f009b)

Uh oh!

vercel Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

unkey-deploy Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Observability score · 31

Uh oh!

This comment has been minimized.

greptile-apps Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Diagram

Uh oh!

greptile-apps Bot Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

FindMalek commented Oct 9, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

izadoesdev commented Oct 8, 2026 •

edited by cubic-dev-ai Bot

Loading

Review fixes (`46f009b`)

vercel Bot commented Oct 8, 2026 •

edited

Loading

unkey-deploy Bot commented Oct 8, 2026 •

edited

Loading

coderabbitai Bot commented Oct 8, 2026 •

edited

Loading

github-actions Bot commented Oct 8, 2026 •

edited

Loading

greptile-apps Bot commented Oct 8, 2026 •

edited

Loading