Skip to content

fix(dashboard): search custom events and balance selector padding - #1133

Merged
izadoesdev merged 2 commits into
mainfrom
codex/events-picker-hotfix
Oct 13, 2026
Merged

izadoesdev merged 2 commits into
mainfrom
codex/events-picker-hotfix

Conversation

@izadoesdev

@izadoesdev izadoesdev commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Users with many custom events had to scroll the event picker to find an event. Add the existing shared searchable picker with keyboard selection, a no-results state, and search reset on reopening while preserving the selected event's properties and URL state.

Give the small segmented control equal 4 px insets, correcting the Daily/Hourly selector's 2 px left versus 4 px top spacing. This hotfix contains only these two UI files and is based on current main.

Validation: full bun run lint, repository bun run check-types, and dashboard tests passed. An isolated synthetic browser fixture verified case-insensitive search, keyboard selection, property and URL updates, no-results recovery, search reset, responsive widths from 320 to 1440 px, and matching 4 px top/left insets. The full authenticated /events route was not running locally.


Summary by cubic

Replaces the custom events dropdown with the shared searchable picker and evens out the small segmented control's padding.

  • The picker adds keyboard selection, a no-results state, and search reset on reopening while preserving the selected event's properties and URL state.
  • The small segmented control now gets equal 4px insets, fixing the previous 2px left versus 4px top spacing.
  • This hotfix touches only these two UI files and is based on current main.

Written for commit 1edd3de. Summary will update on new commits.

View guided diff Turn on auto-fix

@unkey-deploy

unkey-deploy Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Unkey Deploy

Name Status Preview Inspect Updated (UTC)
links (preview) Ready Visit Preview Inspect Oct 13, 2026 4:59pm

@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dashboard Ready Ready Preview Oct 13, 2026 4:59pm UTC
databuddy-status Ready Ready Preview Oct 13, 2026 4:59pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
documentation Skipped Skipped Oct 13, 2026 4:59pm UTC

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9a43202e-c05d-4ecd-9d00-8a437b0398f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Observability score · 92

excellent · unchanged against main · no regression

1 instrumented · 3 partial · 2 dark

Fix first (3)

evlog map v0.8.0 · how the score works · what each check expects

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge, with both previous UI concerns addressed.

Summary

The PR adds the shared searchable custom-event picker and gives the small segmented control equal padding.

  • Custom-event lists are searchable in the property summary.
  • Small segmented controls have matching 4 px insets.

Reviews (2) · Last reviewed commit: "fix(dashboard): address custom event pic..." · Reviewed by Greptile

Comment thread apps/dashboard/components/events/custom-events/property-summary.tsx Outdated
@izadoesdev

Copy link
Copy Markdown
Member Author

@greptileai review

Please review the final head 1edd3de after the two UI guideline fixes. The previous finding is fixed and resolved; local lint, types, dashboard tests, and synthetic picker checks passed.

@izadoesdev
izadoesdev merged commit 1f54d0a into main Oct 13, 2026
27 checks passed
@izadoesdev
izadoesdev deleted the codex/events-picker-hotfix branch October 13, 2026 17:08

This branch was successfully deployed

3 active and 1 inactive deployments
Preview – dashboard — 1edd3de1 Deployed Oct 13, 2026 by vercel[bot]
Preview – databuddy-status — 1edd3de1 Deployed Oct 13, 2026 by vercel[bot]
links - preview — 1edd3de1 Deployed Oct 13, 2026 by unkey-deploy[bot]
Preview – documentation — 1edd3de1 Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant