Repository navigation
Remove trailing semicolon from assert_binary_snapshot! macro body - #946
Merged
max-sixty merged 1 commit intoOct 10, 2026
Merged
Conversation
#940 removed the trailing semicolons from the serialization macro bodies but missed the two-argument arm of assert_binary_snapshot!, so calling it at the end of a block still warns with semicolon_in_expressions_from_non_local_macros on newer toolchains. this drops that semicolon and the one in test_binary.rs, so the test covers it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#940 removed the trailing semicolons from the serialization macro bodies but missed the two-argument arm of
assert_binary_snapshot!, so calling it at the end of a block still warns withsemicolon_in_expressions_from_non_local_macroson newer toolchains. this drops that semicolon and the one intest_binary.rs, so the test covers it (fails on nightly without the fix, the pinned 1.95 doesn't fire the lint here).