Repository navigation
fix: treat lone dash as positional during command discovery - #2518
Closed
ibrahimypr wants to merge 1 commit into
Closed
ibrahimypr wants to merge 1 commit into
ibrahimypr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a runnable root command accepts positional arguments and has a
childsubcommand,root - childcurrently executeschildwith-as its argument. Replacing-with an ordinary filename keeps execution on the root. EnablingTraverseChildrenalso keeps the lone dash on the root, consistent with pflag treating-as a positional argument.Use the existing
isFlagArgpredicate in command discovery and matched-command removal. A lone dash can then stop subcommand discovery like other positional arguments. If an application explicitly defines-as a command name or alias, its command token is removed normally. Flag values and the--terminator retain their existing handling.Validation on macOS arm64 with Go 1.25.3:
--, and as a command name or alias.go test ./...passes.make all(formatting and full tests) andgit diff --checkpass. The optional golangci-lint binary is not installed locally.AI assistance: OpenAI Codex helped implement and test this change.