Repository navigation
feat(sdk): add mTLS client identity support - #2947
Merged
Merged
Conversation
fakedev9999
force-pushed
the
fakedev9999/sdk-client-mtls
branch
from
August 25, 2026 04:06
9779dfa to
d032db6
Compare
fakedev9999
marked this pull request as ready for review
August 25, 2026 04:15
fakedev9999
force-pushed
the
fakedev9999/sdk-client-mtls
branch
from
August 25, 2026 04:21
d032db6 to
0c4318e
Compare
Contributor
|
fakedev9999
force-pushed
the
fakedev9999/sdk-client-mtls
branch
from
August 25, 2026 08:59
0c4318e to
5d20617
Compare
Farhad-Shabani
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The SDK should own transport configuration, while each application should own its environment variables, secret files, and startup policy. This lets callers load credentials from their own secret source and inject the certificate and private key explicitly.
Validation
cargo +1.98.0 fmt --all -- --checkcargo +1.98.0 check -p test-artifactscargo +1.98.0 clippy --all-features --all-targets -- -D warnings -A incomplete-featurescargo +1.98.0 test -p sp1-sdk --features network,blocking --lib, 53 passedThe macOS host cannot link the optional GPU feature because the
icicle_*native libraries are unavailable. Pull request CI covers the GPU-linked jobs.