Repository navigation
Conversation
Signed-off-by: gluedtea <gluedtea@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
verify_proofparses the exit code frompublic_inputs[2]for Plonk and Groth16 proofs.In the Groth16 branch, parsing errors are incorrectly mapped to
SP1VerificationError::Plonkdue to a copy-paste error. This causes callers to receive the wrong public error category when classifying verification failures.This does not affect cryptographic verification correctness. It only affects the SDK's error classification and downstream logging, retry, and diagnostic logic.
Solution
SP1VerificationError::Groth16.public_inputs[2] = "invalid-exit-code"and verifies that the SDK returns theGroth16error variant.PR Checklist