Repository navigation
fix(prover): private method usage - #2997
Open
RungChungo wants to merge 1 commit into
Open
RungChungo wants to merge 1 commit into
RungChungo wants to merge 1 commit into
Conversation
RungChungo
changed the title
RungChungo
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Failed to build sp1-prover due to
error[E0599]: no method named
keepfound for structTempDirin the current scope--> /home/***/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/sp1-prover-6.8.1/src/build.rs:623:36
|
623 | let staging_path = staging_dir.keep();
| ^^^^ private field, not a method
For more information about this error, try
rustc --explain E0599.error: could not compile
sp1-prover(lib) due to 1 previous errorSolution
Change staging_dir.keep() to staging_dir.path()
guessing this was a typo, but fails build
PR Checklist