Skip to content

fix(algebra): keep the test field dependency local - #3029

Open
fakedev9999 wants to merge 3 commits into
mainfrom
fakedev9999/sp1-610-publish-dev-dependency
Open

fakedev9999 wants to merge 3 commits into
mainfrom
fakedev9999/sp1-610-publish-dev-dependency

Conversation

@fakedev9999

@fakedev9999 fakedev9999 commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

What

  • Keep slop-baby-bear as a local test dependency so Cargo omits it from the published slop-algebra package.
  • Update the workspace lockfile from Tokio 1.52.1 to 1.53.3 to clear RUSTSEC-2026-0386.

Why

The versioned test dependency creates a publication cycle between slop-algebra and slop-baby-bear.
The new Tokio advisory blocks the PR advisory check.

Validation

  • cargo +1.99.1 package -p slop-algebra --locked
  • cargo +1.99.1 test -p slop-algebra --lib --locked (2 passed)
  • cargo +1.99.1 check -p sp1-sdk --locked
  • cargo +1.99.1 clippy -p slop-algebra --all-targets --all-features --locked -- -D warnings
  • cargo +1.99.1 fmt --all -- --check
  • Inspected the packaged manifest to confirm slop-baby-bear is omitted.

Notes

Tests from the published archive need slop-baby-bear supplied separately.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor
Test Old New Diff
curve25519_dalek_test_decompressed_noncanonical 7725 7725 0.0000 %
curve25519_dalek_test_add_then_multiply 3222313 2979902 -7.5229 %
bn_test_field_checks 31646 31646 0.0000 %
secp256k1_program_test_recover_v0_30_0_rand_lte_100 5514330 5515528 0.0217 %
bls12_381_tests_test_bls_add_100 10355715 10355715 0.0000 %
bn_test_bn_test_g1_msm_edge 375798 375798 0.0000 %
rust_crypto_rsa_test_pkcs_verify_100 29127917 28867552 -0.8939 %
bls12_381_tests_test_v2_field_checks 29324 29324 0.0000 %
bls12_381_tests_test_point_checks 797024 797024 0.0000 %
curve25519_dalek_test_decompressed_expected_value 4427485 4427485 0.0000 %
sha_test_sha3_expected_digest_lte_100_times 1176451 1176206 -0.0208 %
curve25519_dalek_ng_test_decompressed_noncanonical 189834 189834 0.0000 %
p256_test_field_checks 47543 47543 0.0000 %
bls12_381_tests_test_v2_point_checks 1738384 1738384 0.0000 %
k256_test_point_ops_edge_cases 40933 40933 0.0000 %
bn_test_bn_test_fq_partial_ord 184528 184528 0.0000 %
keccack_test_expected_digest_lte_100 1714467 1707537 -0.4042 %
bls12_381_tests_test_field_checks 29324 29324 0.0000 %
bls12_381_tests_test_sqrt_fp2_100 1620009 1838947 13.5146 %
p256_test_point_checks 347502 347502 0.0000 %
sha_test_sha2_v0_10_8_expected_digest_lte_100_times 1338945 1343549 0.3439 %
bn_test_bn_test_g1_add_100 988638 988610 -0.0028 %
curve25519_dalek_test_zero_msm 83427 83427 0.0000 %
bls12_381_tests_test_inverse_fp2_100 2216948 2216948 0.0000 %
curve25519_dalek_ng_test_zero_msm 125133 125133 0.0000 %
k256_test_recover_rand_lte_100 4443066 4446364 0.0742 %
p256_test_recover_high_hash_high_recid 6198504 6478255 4.5132 %
p256_test_recover_rand_lte_100 15962759 15974309 0.0724 %
sha_test_sha2_v0_11_0_expected_digest_lte_100_times 1332136 1327775 -0.3274 %
sha_test_sha2_v0_9_9_expected_digest_lte_100_times 1253342 1257421 0.3254 %
bn_test_bn_test_g1_add_neg 291962 291962 0.0000 %
k256_test_field_checks 40519 40519 0.0000 %
bn_test_bn_test_fq_inverse_100 786417 786417 0.0000 %
p256_test_verify_rand_lte_100 12036497 12075304 0.3224 %
secp256k1_program_test_recover_rand_lte_100 5520957 5513952 -0.1269 %
bn_test_bn_test_fq_sqrt_100 787385 787379 -0.0008 %
secp256k1_program_test_verify_v0_30_0_rand_lte_100 17090815 17081672 -0.0535 %
k256_test_verify_rand_lte_100 11770548 11781857 0.0961 %
rustcrypto_bigint_test_bigint_mul_add_residue 2053023 2053023 0.0000 %
k256_test_recover_high_hash_high_recid 1963836 1907370 -2.8753 %
bn_test_bn_test_g1_mul_zero 47803 47803 0.0000 %
secp256k1_program_test_verify_rand_lte_100 17108032 17122062 0.0820 %
rustcrypto_bigint_test_bigint_mul_mod_special 1717435 1717435 0.0000 %
p256_test_recover_pubkey_infinity 98144 98144 0.0000 %
sha_test_sha2_v0_10_6_expected_digest_lte_100_times 1342109 1344724 0.1948 %
bls12_381_tests_test_sqrt_fp_100 791834 848233 7.1226 %
bls12_381_tests_test_inverse_fp_100 1197070 1197070 0.0000 %
k256_test_recover_pubkey_infinity 98610 98610 0.0000 %
curve25519_dalek_ng_test_zero_mul 107750 107750 0.0000 %
bls12_381_tests_test_bls_double_100 6284517 6284517 0.0000 %
curve25519_dalek_ng_test_add_then_multiply 4382818 3756835 -14.2827 %
k256_test_schnorr_verify 5772995 5766079 -0.1198 %
curve25519_dalek_test_ed25519_verify 12937429 12938936 0.0116 %
sha_test_sha2_v0_10_9_expected_digest_lte_100_times 1344100 1344613 0.0382 %
bn_test_bn_test_fr_inverse_100 803517 803517 0.0000 %
bn_test_bn_test_g1_double_100 728704 728704 0.0000 %
curve25519_dalek_test_zero_mul 71838 71838 0.0000 %

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant