Repository navigation
fix: scope API V3 GC safe points by namespace and keyspace - #568
Conversation
Signed-off-by: disksing <i@disksing.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
API V3
TransactionClient::gcpreviously resolved locks within its namespace/keyspace but advanced the global PD safe point. Route these updates throughUpdateGCSafePointV2with the complete identity carried per request through the PD client and retry layers.Other client modes retain the global RPC and the existing boolean result. Scoped failures never fall back to a global update, including PD implementations that do not support scoped GC.
Validation: Rust 1.93.0 formatting checks, all 145 library tests, and all-targets clippy with warnings denied passed on Linux. New gRPC tests cover two namespaces sharing a keyspace ID, legacy modes, a newer safe point, PD header errors, and an unsupported scoped RPC.