Repository navigation
Pass run_agents metadata through child launch and confirmation - #16396
Open
warp-agent-staging[bot] wants to merge 3 commits into
Open
warp-agent-staging[bot] wants to merge 3 commits into
warp-agent-staging[bot] wants to merge 3 commits into
Conversation
Contributor
Author
|
This PR was generated with Warp. Comment |
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Pass
run_agentsbatch metadata and child overrides to child-run creation. This lets orchestrators label each child while retaining existing server-owned explicit > inherited > automatic precedence.Review guide
Start with protocol conversion,
RunAgentsExecutordispatch, and remote request preparation. GUI and TUI confirmation reconstruction must preserve both maps. TUI coverage dispatches the normal Accept action and checks the controller’s captured request. Most other edits initialize empty maps at existing constructors. The action variant boxes its request so added metadata does not enlarge every action. MacOS Clippy diagnosed a 320-byte request versus the next-largest 112-byte variant; scoped Linux Clippy alone did not catch that target-dependent layout gate.Metadata persistence also travels through local child creation for consistency; embedded-local and standalone-local environment injection remain out of scope. Hosted/self-hosted metadata comes from the server's environment transport before setup, not from new prompt injection. The runtime rejects raw managed-secret names that collide with injected metadata, including empty values.
Depends on protocol PR #398, pinned at
6b33333f17ae74f1d18769672d6594d095b3f3da. Pair with worker PR #167 and server PR #19546. Deploy this runtime and worker conflict protection before metadata-producing server rollout. Older clients continue to create children with inherited metadata only.The protocol pin also includes existing upstream web-fetch usage fields. Two unrelated exhaustive test constructors gain defaults solely to compile against that additive protocol version. The lockfile changes only the protocol source revision.
Approved collision-check limits: custom-image baked-in ENV and Kubernetes
EnvFromnames are not inspected; operators must avoidWARP_METADATA_there.Linked Issue
REMOTE-3439.
ready-to-specorready-to-implement. This work uses an approved Linear contract, not a GitHub issue with those labels.Testing
Passed 266 tests on the current candidate, covering metadata conversion, independent child overrides, empty-value preservation, remote wire payload, secret protection, and GUI/TUI orchestration confirmation and dispatch.
Command:
cargo nextest run --locked -p ai -p warp -p warp_tui -E 'test(metadata) | test(secret_env_vars) | test(run_agents) | test(orchestration_config) | test(orchestration_block) | test(prepared_remote_request_matches_gui_wire_semantics)' --no-fail-fast.Also passed
cargo clippy --locked -p ai -p warp -p warp_tui -p warp_graphql --all-targets --tests -- -D warnings, followed by./script/format. Both commands usedCARGO_HOME=/home/agent/.cargo CARGO_TARGET_DIR=/tmp/warp-metadata-target.The MacOS enum-size diagnostic is addressed by boxing the action payload, without suppressing the lint. Normal push triggered eligible cross-platform CI on the new head. Those results are pending, not green; green required checks remain a merge gate.
An intermediate Clippy attempt exhausted disk; deleting only temporary Cargo incremental caches recovered capacity and the retry passed. No live hosted service launch or local Mac/Windows runner was exercised.
./script/run. No rendering change or computer-use verification scope.Agent Mode
CHANGELOG-OZ: Orchestrators can attach batch and per-child run metadata for grouping and setup workflows.
Plans: